Scenario Builder: own-soil units join a theatre only within reach #37

Manually merged

vinny merged 0 commits from vinny/builder-own-soil into master

2026-10-14 02:06:44 -04:00

AGit

vinny commented

2026-10-14 02:05:35 -04:00

Owner

A unit on its own country's soil joins a theatre only when it is within reach of it.

Found live (2026-10-14): the Baltic laboratory plan (#7) took 643 Russian units based more than 200 nm outside its theatres: the Pacific Fleet at Vladivostok, the Black Sea Fleet, Moscow's and Krasnodar's units. A Sea of Japan plan took western Russia.
Cause: own_soil sent every unit on its own country's soil outside the theatre boxes to the nearest theatre holding that country's land, however far. It was made for Saudi squadrons a few hundred miles outside a Gulf box.
Fix: a squadron joins within 600 nm of the theatre's edge, a ship, submarine or site within 200 nm. The Saudi and Iranian cases still join. New test test_own_soil_reaches_only_so_far_outside_a_theatre; documented in docs/SCENARIO_BUILDER.md.
Test fix: the shared world fixture now builds its installation index. Three tests had read it unbuilt, passing only when an earlier test happened to build it.

🤖 Generated with Claude Code

A unit on its own country's soil joins a theatre only when it is within reach of it. - **Found live (2026-10-14):** the Baltic laboratory plan (#7) took 643 Russian units based more than 200 nm outside its theatres: the Pacific Fleet at Vladivostok, the Black Sea Fleet, Moscow's and Krasnodar's units. A Sea of Japan plan took western Russia. - **Cause:** `own_soil` sent every unit on its own country's soil outside the theatre boxes to the nearest theatre holding that country's land, however far. It was made for Saudi squadrons a few hundred miles outside a Gulf box. - **Fix:** a squadron joins within 600 nm of the theatre's edge, a ship, submarine or site within 200 nm. The Saudi and Iranian cases still join. New test `test_own_soil_reaches_only_so_far_outside_a_theatre`; documented in `docs/SCENARIO_BUILDER.md`. - **Test fix:** the shared `world` fixture now builds its installation index. Three tests had read it unbuilt, passing only when an earlier test happened to build it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

vinny added 3 commits

2026-10-14 02:05:36 -04:00

Scenario Builder: own-soil units join a theatre only within reach of it ff7a66bf24

A unit based on its own country's soil outside every theatre box joined the
nearest theatre holding its country's land, however far: on 2026-10-14 the
Baltic laboratory plan took 643 Russian units based more than 200 nm outside
its theatres (the Pacific Fleet at Vladivostok, the Black Sea Fleet, Moscow's
batteries), and a Sea of Japan plan took western Russia. Own soil now counts
within 600 nm of the theatre's edge for a squadron and 200 nm for a ship,
submarine or site; the Saudi and Iranian cases it was made for still join.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Builder tests: the shared world fixture builds its installation index 6b1420e7f2

Two drafting tests and one deploy test read index.items from the module's
world fixture, which never built the index; they passed only when an
earlier test happened to build it, and failed on 2026-10-14. The fixture
now builds it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Version 0.7.21 (builder-own-soil)

check / check (ubuntu-latest) (push) Has been cancelled

Details

check / check (windows-latest) (push) Has been cancelled

Details

check / check (ubuntu-latest) (pull_request) Has been cancelled

Details

check / check (windows-latest) (pull_request) Has been cancelled

Details

902ef050b2

vinny manually merged commit 902ef050b2 into master

2026-10-14 02:06:44 -04:00