vinny/CMOnet
Watch
1
0
Fork
You've already forked CMOnet
 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Flows: a review run is told the order it acts under #163

Manually merged
vinny merged 0 commits from vinny/review-order into master 2026-10-27 23:40:05 -04:00 AGit
Conversation 0 Commits - Files changed -
vinny commented 2026-10-27 23:38:42 -04:00
Owner
Copy link

A flow review job acts under the President's most recent current order (its ticket names it), but the cmonet-flow-start event took the order from job.order_id, which reviews don't have, so the flow saw order null. Live 2026-10-28: the order's own run failed while the model server was unreachable, so the flow memory never got the order's words and each later review would brief the General "no order yet" while CMOnet fenced its writes under that order. The start event now uses the ticket's order. Test: tests/flows/test_runner.py::test_a_review_run_is_told_the_order_it_acts_under; tests/flows passes. 🤖 Generated with Claude Code

A flow review job acts under the President's most recent current order (its ticket names it), but the cmonet-flow-start event took the order from job.order_id, which reviews don't have, so the flow saw order null. Live 2026-10-28: the order's own run failed while the model server was unreachable, so the flow memory never got the order's words and each later review would brief the General "no order yet" while CMOnet fenced its writes under that order. The start event now uses the ticket's order. Test: tests/flows/test_runner.py::test_a_review_run_is_told_the_order_it_acts_under; tests/flows passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
A review job has no order of its own and acts under the President's most
recent current order (owner decision 2026-10-03): its ticket names that
order, but the flow's start event was built from the job's order_id, so
it said order null. Live 2026-10-28 the order's own run failed while the
model server was down, the flow's memory never held its words, and every
review after it would have briefed the General "no order yet" while its
writes were fenced under the order. The start event now takes the
ticket's order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Version 0.7.105 (review-order)
Some checks failed
check / check (ubuntu-latest) (push) Has been cancelled
Details
check / check (windows-latest) (push) Has been cancelled
Details
check / check (ubuntu-latest) (pull_request) Has been cancelled
Details
check / check (windows-latest) (pull_request) Has been cancelled
Details
0a233ea201
vinny manually merged commit 0a233ea201 into master 2026-10-27 23:40:05 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
vinny/CMOnet!163
No description provided.