Library: missions.set_targets never names the units behind an air base #154

Manually merged

vinny merged 0 commits from vinny/hidden-targets into master 2026-10-17 17:45:57 -04:00 AGit

Conversation 0 Commits - Files changed -

vinny commented 2026-10-17 17:40:48 -04:00

Owner

Copy link

Summary

• Syncs missions.set_targets from tester ef27991, which fixes tester issue #2 (a hidden-enemy-links leak).

• CMO lists an air base contact as a strike target by the true units behind it. The tool took its current targets from the raw target list, so those unit GUIDs reached:

  • its result (removed, expect.target_ids);
  • a refusal message;
  • through the expectation, tester.check_mission's note.

  The result reaches CMOnet's agents.

• Now only the side's contacts are named. Replace still removes the hidden units and counts them (unnamed_removed). A refused removal of one leaves out CMO's reason, which may name the unit.

• No description change, so the G2 goldens stay as they are.

• The evidence's library adapter revision follows the new manifest.

Test plan

• Tester: three new tests in tests/test_partial_writes.py; the hidden-ID check now covers the air base units. All four air-base target tests fail on the old Lua. Full tester suite: 1099 passed.
• CMOnet: library, catalog and verifier tests pass (89), including the manifest and library Lua rules check.
• Background tools/check.py --rev

🤖 Generated with Claude Code

## Summary - Syncs `missions.set_targets` from tester ef27991, which fixes tester issue #2 (a hidden-enemy-links leak). - CMO lists an air base contact as a strike target by the true units behind it. The tool took its current targets from the raw target list, so those unit GUIDs reached: - its result (`removed`, `expect.target_ids`); - a refusal message; - through the expectation, `tester.check_mission`'s note. The result reaches CMOnet's agents. - Now only the side's contacts are named. Replace still removes the hidden units and counts them (`unnamed_removed`). A refused removal of one leaves out CMO's reason, which may name the unit. - No description change, so the G2 goldens stay as they are. - The evidence's library adapter revision follows the new manifest. ## Test plan - [x] Tester: three new tests in `tests/test_partial_writes.py`; the hidden-ID check now covers the air base units. All four air-base target tests fail on the old Lua. Full tester suite: 1099 passed. - [x] CMOnet: library, catalog and verifier tests pass (89), including the manifest and library Lua rules check. - [ ] Background `tools/check.py --rev` 🤖 Generated with [Claude Code](https://claude.com/claude-code)

vinny added 2 commits 2026-10-17 17:40:49 -04:00

Library: missions.set_targets never names the units behind an air base ... 4ab48a82a0

Synced from tester ef27991 (tester issue #2). CMO lists an air base contact
as a strike target by the true units behind it; the tool's result, its
refusal message and its read-back expectation named those unit GUIDs, and
the result reaches CMOnet's agents. Now they hold only the side's contacts;
replace still removes the hidden units and counts them (unnamed_removed).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Version 0.7.96 (hidden-targets) 002889cfc4

vinny added 1 commit 2026-10-17 17:41:42 -04:00

Evidence: the library's new adapter revision ... c4641b059d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

vinny manually merged commit c4641b059d into master 2026-10-17 17:45:57 -04:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

vinny/CMOnet!154

No description provided.