Stage 3 tests still build tickets through the legacy GeneralWorker #11

New issue

Closed

opened 2026-10-13 05:50:47 -04:00 by vinny · 0 comments

vinny commented

2026-10-13 05:50:47 -04:00

Owner

src/cmonet/general/worker.py and src/cmonet/general/context.py (449 lines) are not wired in server.py. They are marked legacy (general/context.py, around line 107), and only tests use them:

tests/stage3/helpers.py (ticket_for) and tests/library/world.py make every stage-3 execution ticket through GeneralWorker._begin / _accept.
tests/stage3/test_general.py has 16 tests on the worker itself.

So many execution tests start from a decision recorded the stage-3 way, not the way agents/runtime.py records it today.

Proposal:

Move the helpers to the current runtime's ticket path.
Delete the worker tests and the two modules (repository hygiene, AGENTS.md).

Found in the 2026-10-13 review (PR #1). PR #1 removed other dead code: domain/ports.py and seven unused functions.

`src/cmonet/general/worker.py` and `src/cmonet/general/context.py` (449 lines) are not wired in `server.py`. They are marked legacy (`general/context.py`, around line 107), and only tests use them: - `tests/stage3/helpers.py` (`ticket_for`) and `tests/library/world.py` make every stage-3 execution ticket through `GeneralWorker._begin` / `_accept`. - `tests/stage3/test_general.py` has 16 tests on the worker itself. So many execution tests start from a decision recorded the stage-3 way, not the way `agents/runtime.py` records it today. Proposal: 1. Move the helpers to the current runtime's ticket path. 2. Delete the worker tests and the two modules (repository hygiene, AGENTS.md). Found in the 2026-10-13 review (PR #1). PR #1 removed other dead code: `domain/ports.py` and seven unused functions.

vinny referenced this issue

2026-10-13 05:52:19 -04:00

Fixes from the 2026-10-13 review: metrics, General menu, event loop, code health #1

vinny referenced this issue from a pull request that will close it,

2026-10-13 20:25:53 -04:00

Retire the legacy GeneralWorker; its tests run on the agent runtime #21

vinny referenced this issue from a commit

2026-10-13 20:34:42 -04:00

Retire Stage 3's GeneralWorker; its tests run on the agent runtime (issue #11)

vinny closed this issue

2026-10-13 20:35:14 -04:00